https://bugzilla.redhat.com/show_bug.cgi?id=653917
--- Comment #12 from Christopher Meng <cicku...@gmail.com> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in gimagereader See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v3 or later)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck: *No copyright* GPL (v3 or later) -------------------------------- gimagereader-2.90/src/AsyncQueue.hh GPL (v2 or later) ----------------- gimagereader-2.90/build/ltmain.sh GPL (v3 or later) ----------------- gimagereader-2.90/src/Acquirer.cc gimagereader-2.90/src/Acquirer.hh gimagereader-2.90/src/Application.hh gimagereader-2.90/src/Config.cc gimagereader-2.90/src/Config.hh gimagereader-2.90/src/ConfigSettings.cc gimagereader-2.90/src/ConfigSettings.hh gimagereader-2.90/src/CrashHandler.cc gimagereader-2.90/src/CrashHandler.hh gimagereader-2.90/src/DisplayManipulator.cc gimagereader-2.90/src/DisplayManipulator.hh gimagereader-2.90/src/DisplayRenderer.cc gimagereader-2.90/src/DisplayRenderer.hh gimagereader-2.90/src/DisplaySelection.cc gimagereader-2.90/src/DisplaySelection.hh gimagereader-2.90/src/Displayer.cc gimagereader-2.90/src/Displayer.hh gimagereader-2.90/src/Geometry.hh gimagereader-2.90/src/MainWindow.cc gimagereader-2.90/src/MainWindow.hh gimagereader-2.90/src/Notifier.cc gimagereader-2.90/src/Notifier.hh gimagereader-2.90/src/OutputManager.cc gimagereader-2.90/src/OutputManager.hh gimagereader-2.90/src/Recognizer.cc gimagereader-2.90/src/Recognizer.hh gimagereader-2.90/src/Scanner.cc gimagereader-2.90/src/Scanner.hh gimagereader-2.90/src/ScannerSane.hh gimagereader-2.90/src/ScannerTwain.hh gimagereader-2.90/src/SourceManager.cc gimagereader-2.90/src/SourceManager.hh gimagereader-2.90/src/UndoableBuffer.cc gimagereader-2.90/src/UndoableBuffer.hh gimagereader-2.90/src/Utils.cc gimagereader-2.90/src/Utils.hh gimagereader-2.90/src/common.hh gimagereader-2.90/src/main.cc Unknown or generated -------------------- gimagereader-2.90/autogen.sh gimagereader-2.90/packaging/win32/makeinstaller.sh [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: glib-compile-schemas is run in %postun and %posttrans if package has *.gschema.xml files. Note: gschema file(s) in gimagereader [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in gimagereader [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: gimagereader-2.90-2.fc21.i686.rpm gimagereader-2.90-2.fc21.src.rpm gimagereader.i686: W: spelling-error %description -l en_US tesseract -> actress gimagereader.i686: W: spelling-error %description -l en_US screenshots -> screen shots, screen-shots, screens hots gimagereader.i686: W: spelling-error %description -l en_US multipage -> multistage gimagereader.i686: E: description-line-too-long C - Basic editing of output text, including search/replace and removing line breaks gimagereader.i686: W: no-manual-page-for-binary gimagereader gimagereader.src: W: spelling-error %description -l en_US tesseract -> actress gimagereader.src: W: spelling-error %description -l en_US screenshots -> screen shots, screen-shots, screens hots gimagereader.src: W: spelling-error %description -l en_US multipage -> multistage gimagereader.src: E: description-line-too-long C - Basic editing of output text, including search/replace and removing line breaks gimagereader.src: W: invalid-url Source0: gimagereader-2.90.tar.xz 2 packages and 0 specfiles checked; 2 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gimagereader gimagereader.i686: W: spelling-error %description -l en_US tesseract -> actress gimagereader.i686: W: spelling-error %description -l en_US screenshots -> screen shots, screen-shots, screens hots gimagereader.i686: W: spelling-error %description -l en_US multipage -> multistage gimagereader.i686: E: description-line-too-long C - Basic editing of output text, including search/replace and removing line breaks gimagereader.i686: W: no-manual-page-for-binary gimagereader 1 packages and 0 specfiles checked; 1 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- gimagereader (rpmlib, GLIBC filtered): /bin/sh libatk-1.0.so.0 libatkmm-1.6.so.1 libc.so.6 libcairo-gobject.so.2 libcairo.so.2 libcairomm-1.0.so.1 libdl.so.2 libenchant.so.1 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-3.so.0 libgdk_pixbuf-2.0.so.0 libgdkmm-3.0.so.1 libgio-2.0.so.0 libgiomm-2.4.so.1 libglib-2.0.so.0 libglibmm-2.4.so.1 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-3.so.0 libgtkmm-3.0.so.1 libgtkspell3-3.so.0 libgtkspellmm-3.0.so.0 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangomm-1.4.so.1 libpoppler-glib.so.8 libpthread.so.0 libsane.so.1 libsigc-2.0.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libtesseract.so.3 rtld(GNU_HASH) Provides -------- gimagereader: application() application(gimagereader.desktop) gimagereader gimagereader(x86-32) mimehandler(image/bmp) mimehandler(image/gif) mimehandler(image/jpeg) mimehandler(image/png) mimehandler(image/svg+xml) mimehandler(image/tiff) mimehandler(image/x-bmp) mimehandler(image/x-ico) mimehandler(image/x-pcx) mimehandler(image/x-png) mimehandler(image/x-tga) mimehandler(image/xpm) Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn gimagereader-2.90-2.fc21.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ------------------------------- Fix rpmlint E issues, and add the missing script, then I will approve this one. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
