https://bugzilla.redhat.com/show_bug.cgi?id=1020942



--- Comment #36 from Jeremy Newton <alexjn...@gmail.com> ---
(In reply to Richard Shaw from comment #34)
> Ok, one thing we need to fix, if you run rpmlint on the installed packages
> it finds a BUNCH of "unused-direct-shlib-dependency"
> 
> Which means:
> $ rpmlint -I unused-direct-shlib-dependency
> unused-direct-shlib-dependency:
> The binary contains unused direct shared library dependencies.  This may
> indicate gratuitously bloated linkage; check that the binary has been linked
> with the intended shared libraries only.
> 
> If the build honors LDFLAGS then a quick solution is to use:
> export LDFLAGS='-Wl,--as-needed"
> just before configure.

Good catch, I must have missed this. I added the line, hopefully this fixes it;
I haven't had time to build it yet.

(In reply to noobie from comment #35)
> I just tried your package and stumbled upon the following problem:
> in wx-config line 34: wxconfig=$libdir/wx/config/gtk2-unicode-$version 
> will become wxconfig=$libdir/wx/config/gtk2-unicode-3.0 (for now) but the
> package creates "gtk3-unicode-3.0".... thereby the if-statement in line 40
> will always fail. (Maybe I just screwed it while building the package ?)

No this is indeed a bug, thanks for catching this! :)

Here's the new files:
SPEC
https://dl.dropboxusercontent.com/u/42480493/wxGTK3.spec

SRPM
https://dl.dropboxusercontent.com/u/42480493/wxGTK3-3.0.0-4.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to