https://bugzilla.redhat.com/show_bug.cgi?id=1056057
--- Comment #4 from Debarshi Ray <debars...@redhat.com> ---
(In reply to Kalev Lember from comment #3)
Thanks for the review!
> Looks good to me, just a small issue with the Source URL. As yaneti pointed
> out on IRC, the way to make the github URLs work (as recommended in the
> packaging guidelines) would be to use the git hash that the tag points to.
> Right now you are using the hash of the tag object; should be the hash that
> the commit points to.
>
> $ git show-ref --dereference v0.4.0
> 0e9d8bd48f80daea4f352a33ba1aa35af180dd46 refs/tags/v0.4.0
> 3fcae066b44195c187b5611acfd511b9a87850d0 refs/tags/v0.4.0^{}
>
> ^^ e.g. the 2nd hash here.
I see. The guidelines need to be updated in that case.
> This is just a minor issue and won't block the package from getting
> imported, but would be great if you could fix it so that 'spectool -g'
> starts working.
Fixed.
Spec: http://rishi.fedorapeople.org/dleyna-server.spec
SRPM: http://rishi.fedorapeople.org/dleyna-server-0.4.0-3.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
