https://bugzilla.redhat.com/show_bug.cgi?id=1064576

Cole Robinson <crobi...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |crobi...@redhat.com
           Assignee|nob...@fedoraproject.org    |crobi...@redhat.com
              Flags|                            |fedora-review+



--- Comment #2 from Cole Robinson <crobi...@redhat.com> ---
fedora-review doesn't flag anything interesting, nothing major from manual
review. minor bits:

- %{modname} can be used in Name: as well
- I've seen people use %{name} for Patch lines as well
-
https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Eggs_using_Setuptools
 : suggests simply doing %{python2_sitelib}/* in %files to catch the module and
egg-info directory
- The package description doesn't explicitly distinguish python2/python3
besides including the package name.

But those are all minor points that I'll leave to your discretion. setting
fedora-review+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to