https://bugzilla.redhat.com/show_bug.cgi?id=1079064
Adrien Vergé <adrienve...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |adrienve...@gmail.com
--- Comment #1 from Adrien Vergé <adrienve...@gmail.com> ---
Hi dulsi,
There are a few things you need to correct.
Please cut the %description line to fit 80 characters.
Even for your first release, you need to put a %changelog entry in the spec.
See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
If you install a .desktop file, please use:
desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
update-desktop-database is used to rebuild the cache database for MIME types.
If your program doesn't handle specific MIME types, you can remove it.
Replace $RPM_BUILD_ROOT with %{buildroot}.
From what I read in your Makefile:
LIBS = $(SDL_LDFLAGS) -lSDL_image -lSDL_mixer -lexpat -lSDL_ttf -lphysfs \
-lboost_filesystem -lboost_system -lpng
your package depends on some libraries. You need to declare them explicitely
with Requires entries. Please refer to this section:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requires_2
Last thing, btbuilder is under GPLv2+, but includes artwork that "is not
necessarily under the GPL": is it allowed? I'm not a specialist, but I think
it's worth checking :)
Thank you
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
