https://bugzilla.redhat.com/show_bug.cgi?id=1079745
Ralf Corsepius <rc040...@freenet.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rc040...@freenet.de
--- Comment #1 from Ralf Corsepius <rc040...@freenet.de> ---
* These Requires: should be removed from the *.spec:
Requires: perl(XML::Parser)
Requires: perl(IO::Scalar)
Requires: perl(File::Basename)
Requires: perl(Spreadsheet::WriteExcel::Utility)
Rpm automatically detects them, causing the manually specified ones to appear
twice on the resulting binary rpms.
* BuildRequires: perl(Spreadsheet::WriteExcel)
should match the run-time requirement:
Requires: perl(Spreadsheet::WriteExcel) >= 0.42
i.e. change
BuildRequires: perl(Spreadsheet::WriteExcel)
into
BuildRequires: perl(Spreadsheet::WriteExcel) >= 0.42
* I'd recommend to "chmod"s the source-files in %build ("Fix the sources")
instead to "chmod" them after installation in %install ("Workaround the bug").
* The package ships a LICENCE file
=> MUST add LICENCE to %doc
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
