https://bugzilla.redhat.com/show_bug.cgi?id=1079615
--- Comment #2 from Ralf Corsepius <rc040...@freenet.de> --- (In reply to Petr Pisar from comment #1) > TODO: I would speel `NativeTrait-like' as `Native-trait-like' or > `NativeTraits-like' because `NativeTrait' is neither word nor Moose term > (MouseX::NativeTraits). Not changed: This is upstream's description, they are using inside of the package and in CPAN > TODO: You can replace `PERL_INSTALL_ROOT' with `DESTDIR' argument in the > %install section. I kept PERL_INSTALL_ROOT. > TODO: Package either README or README.mkdn. They are redundant. > TODO: Do not package dist.ini. There is nothing spectacular for the end > users besides the git URL. Done. This was an oversight on my part. > TODO: Constrain `BuildRequire: perl(ExtUtils::MakeMaker)' with `>= 6.30' > (Makefile.PL:7). Done. > TODO: You should build-require both `perl(namespace::clean)' and > `perl(namespace::autoclean)', or none for consistency. Done. BR'ing both, now. > TODO: Build-require `perl(strict)' (Makefile.PL:2). > TODO: Build-require `perl(warnings)' (Makefile.PL:3). Done. > FIX: (Build-)require Data::Perl::* modules instead of Data::Perl itself > (Data::Perl::Role::Collection::Array, Data::Perl::Role::Collection::Hash, > Data::Perl::Role::String, Data::Perl::Role::Number, Data::Perl::Role::Bool). > These are loaded via Moo's `with' keyword. Done under protest. All this does it to bloat the dependency tree with redundant deps at no technical benefits. > FIX: Do not Build-require `perl(Role::Tiny)'. It's not used anywhere. It's > loaded via Role::Tiny::With. Done. > FIX: Build-require `perl(Moo::Role)' (t/handlesvia_in_role.t:7). Done. > TODO: Build-require `perl(overload)' (t/from-moose/trait_array.t:98). Done. Updated package: Spec URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-HandlesVia.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-HandlesVia-0.001005-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
