Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603233

--- Comment #2 from Thomas Spura <toms...@fedoraproject.org> 2010-06-11 
22:00:56 EDT ---
Thanks for looking into this so fast :)

(In reply to comment #1)
> The spec file is fine, only some suggestions:
> 1.BuildRequires:  libstdc++-devel is not needed in mock

I was unsure, so I left this in, but deleted now.

> 2.man3 should be moved to -devel subpackage.

Done.

> 3.Group:          Development/Libraries should be moved to -devel subpackage
> 
> The group for main package is System Environment/Libraries    

Right, done.


rpmlint is now completely clean:
$ rpmlint ./zeromq-2.0.7-2.fc13.src.rpm ./x86_64/zeromq-*
4 packages and 0 specfiles checked; 0 errors, 0 warnings.


Spec URL: http://tomspur.fedorapeople.org/review/zeromq.spec
SRPM URL: http://tomspur.fedorapeople.org/review/zeromq-2.0.7-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to