Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #20 from luke kenneth casson leighton <l...@lkcl.net> 2010-06-12 19:24:16 EDT --- (In reply to comment #3) > > I found the above specfile comment a little unclear; it looks like it was > > copied from upstream instructions, but it immediately raises questions: do > > the > > pyjamas libraries get installed, and if so where? > > yeah, I copied this from upstream. Reworded it now. > New wording: > > # NOTE: we only byte-compile the library files installed in the normal > # fedora python_sitelib. All other .py files are left alone. > # This is due to those files replacing/overriding core modules. > # They should never be run from anything but pyjamas itself, nor > # should they be byte compiled. that's a pretty good rewording. > On licensing: > > - I think it does boil down to ASL2 > - The pygwt.js should be ASL2 (at least google web toolkit is ASL2.0). yes. we had to ask the GWT about this, and they specifically placed all files with a copyright notice, ASL2, juuust for us, explicitly, whereas it was implicit before. > - The contrib/copyright_check.py doesn't run, ohh... ah, that'll be... yes. change it to read ../copyright not ../debian/copyright and it'll work. l. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
