https://bugzilla.redhat.com/show_bug.cgi?id=1083962

Volker Fröhlich <volke...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volke...@gmx.at



--- Comment #2 from Volker Fröhlich <volke...@gmx.at> ---
Drop "%defattr(-,root,root)"; no longer necessary, as it is default.

Use %global instead of %define.

I assume you can drop "Requires: (mariadb|mysql)-libs and -embedded" and leave
the dependency generation to rpmbuild.

"%if 0%{?fedora} >= 18" is outdated.

"Requires:    /sbin/ldconfig" doesn't have to be specified.

Should you add a user to run the service at?

The clean section was only necessary up to and including EL5. Same goes for
buildroot and "rm -rf %{buildroot}".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to