https://bugzilla.redhat.com/show_bug.cgi?id=1084680
Ralf Corsepius <rc040...@freenet.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rc040...@freenet.de
--- Comment #1 from Ralf Corsepius <rc040...@freenet.de> ---
Quite a number of issues with this package:
[MUSTFIX]
1.building is non-verbose:
make -j4
CC FPIC rbtree.o
CC FPIC common.o
CC FPIC preload.o
CC FPIC lockdep.o
It's impossible to check this package is being built correctly from build.log.
2. Package ships static lib in main-package.
Shipping static libs is strongly discouraged in Fedora - Should you insist on
shipping them, they must be shipped in separate *-static subpackage.
3. Shared library doesn't provide SONAME
# objdump -p usr/lib/liblockdep.so | grep SONAME
Please contact upstream to provide one.
4. The libraries are not installed %{_libdir}, as they are supposed to be:
# rpm -qlp liblockdep-0.0.1-1.fc20.x86_64.rpm
/usr/lib/liblockdep.a
/usr/lib/liblockdep.so
5. Package ships libraries, but doesn't ship corresponding headers.
Normally this doesn't make sense.
[CONSIDER]
6. Consider to split the package into <main>, *-devel and *-static.
Should you not want to split the program from the shared-lib into a separte
*-devel package, then the <main> package must provide corresponding
*-devel-provides.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
