https://bugzilla.redhat.com/show_bug.cgi?id=1076448
Christopher Meng <cicku...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
--- Comment #1 from Christopher Meng <cicku...@gmail.com> ---
1. Systemd service file missing, please create one.
2. %doc %{_mandir}/man8/darkstat.8*
No %doc please.
3. %attr(755,-,-) %{_sbindir}/darkstat
Why attr()? Can you do that in %install?
4. It should have its own user and group.
5. Drop the group tag if you want.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
