https://bugzilla.redhat.com/show_bug.cgi?id=1057991
Dridi Boukelmoune <dridi.boukelmo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #22 from Dridi Boukelmoune <dridi.boukelmo...@gmail.com> ---
(In reply to Kenjiro Nakayama from comment #21)
> > Also you've removed the file `%{bashcompdir}/ag` instead of the file
> > `/usr/share/the_silver_searcher/completions/ag.bashcomp.sh`.
>
> Added "rm -f
> $RPM_BUILD_ROOT%{_datadir}/the_silver_searcher/completions/ag.bashcomp.sh"
You should remove $RPM_BUILD_ROOT%{_datadir}/%{name} instead, because we end up
with two empty directories:
$ rpmls
1057991-the_silver_searcher/results/the_silver_searcher-0.21.0-1.fc21.x86_64.rpm
-rwxr-xr-x /usr/bin/ag
drwxr-xr-x /usr/share/bash-completion
drwxr-xr-x /usr/share/bash-completion/completions
-rw-r--r-- /usr/share/bash-completion/completions/ag
drwxr-xr-x /usr/share/doc/the_silver_searcher
-rw-r--r-- /usr/share/doc/the_silver_searcher/LICENSE
-rw-r--r-- /usr/share/doc/the_silver_searcher/README.md
-rw-r--r-- /usr/share/man/man1/ag.1.gz
drwxr-xr-x /usr/share/the_silver_searcher
drwxr-xr-x /usr/share/the_silver_searcher/completions
See the last 2 lines ? Not very useful.
Other than that, everything else is fine: package approved! I believe you will
fix this while importing the package.
Thank you again for bringing ag to Fedora :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
