Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=580681 Martin Gieseking <martin.giesek...@uos.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.giesek...@uos.de --- Comment #1 from Martin Gieseking <martin.giesek...@uos.de> 2010-06-15 15:35:46 EDT --- Hi Damien, the package looks almost fine to me. Just two suggestions: - The tarball contains a couple of tests which should be executed in a %check section (with "make check"). - be more specific in the %files sections: %{_includedir}/* => %{_includedir}/%{name}.h %{_libdir}/*.so.* => %{_libdir}/%{name}.so.* %{_libdir}/*.so => %{_libdir}/%{name}.so -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
