https://bugzilla.redhat.com/show_bug.cgi?id=1093407
--- Comment #1 from Antonio Trande <anto.tra...@gmail.com> --- - Please, use macro and not hardlinks: sed -i \ -e 's|PREFIX = /usr/local|PREFIX = %{_prefix}|' \ -e 's|PLGDEST = $(DESTDIR)$(PREFIX)/lib/epgd/plugins|PLGDEST = $(DESTDIR)%{_libdir}/epgd|' \ Make.config - The 'vdr-epg-daemon-eb7f12a6c44b3615b5ecf6b2c4b7bb354ecc5d87/tools/curlfuncs.cpp' file is released with a BSD(3clause) license and it's involved in the compilation. (http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario) Also, COPYING file reports a GPLv2 license. Fix the License tag. - %{_libdir}/epgd is not owned by the package - %{_libdir}/mysql/plugin is owned by 'mariadb-server'. It's a Requires package. - Optimization flags are not honored. (http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags) - Why 'Requires: vdr' is not explicit like your others VDR plugins ? - Please, leave a comment about upstream patch. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 59 files have unknown license. Detailed output of licensecheck in /home/sagitter/1093407-vdr-epg- daemon/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/epgd [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/epgd, /usr/lib64/mysql/plugin [!]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vdr-epg-daemon-0.1.0-4.20140428giteb7f12a.fc21.x86_64.rpm vdr-epg-daemon-0.1.0-4.20140428giteb7f12a.fc21.src.rpm vdr-epg-daemon.x86_64: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal vdr-epg-daemon.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-epg-daemon.x86_64: E: non-standard-executable-perm /usr/lib64/mysql/plugin/mysqlepglv.so 0775L vdr-epg-daemon.x86_64: E: non-standard-executable-perm /usr/bin/epgd 0775L vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-tool vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-showmerge vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-dropall vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-ls-channelids vdr-epg-daemon.src: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal vdr-epg-daemon.src: W: spelling-error %description -l en_US epgd -> deep vdr-epg-daemon.src: W: spelling-error %description -l en_US mysql -> myself vdr-epg-daemon.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-epg-daemon.src: W: file-size-mismatch epgd-tool.diff = 329, http://projects.vdr-developer.org/attachments/1691/epgd-tool.diff = 5427 2 packages and 0 specfiles checked; 2 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint vdr-epg-daemon vdr-epg-daemon.x86_64: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal vdr-epg-daemon.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-epg-daemon.x86_64: E: non-standard-executable-perm /usr/lib64/mysql/plugin/mysqlepglv.so 0775L vdr-epg-daemon.x86_64: E: non-standard-executable-perm /usr/bin/epgd 0775L vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-tool vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-showmerge vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-dropall vdr-epg-daemon.x86_64: W: no-manual-page-for-binary epgd-ls-channelids 1 packages and 0 specfiles checked; 2 errors, 7 warnings. # echo 'rpmlint-done:' Requires -------- vdr-epg-daemon (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/perl config(vdr-epg-daemon) libarchive.so.13()(64bit) libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libexslt.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjansson.so.4()(64bit) libm.so.6()(64bit) libmysqlclient.so.18()(64bit) libmysqlclient.so.18(libmysqlclient_18)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxslt.so.1()(64bit) libxslt.so.1(LIBXML2_1.0.11)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) perl(Getopt::Long) perl(strict) rtld(GNU_HASH) vdr Provides -------- vdr-epg-daemon: config(vdr-epg-daemon) libepgd-epgdata.so()(64bit) vdr-epg-daemon vdr-epg-daemon(x86-64) Unversioned so-files -------------------- vdr-epg-daemon: /usr/lib64/epgd/libepgd-epgdata.so vdr-epg-daemon: /usr/lib64/mysql/plugin/mysqlepglv.so Source checksums ---------------- http://projects.vdr-developer.org/git/vdr-epg-daemon.git/snapshot/vdr-epg-daemon-eb7f12a6c44b3615b5ecf6b2c4b7bb354ecc5d87.tar.bz2 : CHECKSUM(SHA256) this package : 6198c7ab03ebf02c66b9c1f6fed290810dbc5fe5fda7a282b5f670b8cac88645 CHECKSUM(SHA256) upstream package : 6198c7ab03ebf02c66b9c1f6fed290810dbc5fe5fda7a282b5f670b8cac88645 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free -b 1093407 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review