https://bugzilla.redhat.com/show_bug.cgi?id=1087740



--- Comment #2 from Remi Collet <fed...@famillecollet.com> ---
> [!]: License field in the package spec file matches the actual license.
> So GPLv2 deducted.

Fixed

> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /etc/horde
> Require horde needed.

Requires:       php-pear(%{pear_channel}/horde) >= 5.0.0
Requires:       php-pear(%{pear_channel}/horde) <  6.0.0

> [!]: Package consistently uses macros (instead of hard-coded directory
> names).
> Please replace:
> %setup -q -c -T
> tar xif %{SOURCE0}

This was required by a broken archive in previous version
Fixed.

[!]: %check is present and all tests pass.

Have to wait for next major version of the Framework.


https://github.com/remicollet/remirepo/commit/93f346f2336fa4bdd4fc79cd10f2a2442813b89e

Spec:
https://raw.githubusercontent.com/remicollet/remirepo/93f346f2336fa4bdd4fc79cd10f2a2442813b89e/php/horde/php-horde-nag/php-horde-nag.spec
Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-nag-4.1.4-2.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to