https://bugzilla.redhat.com/show_bug.cgi?id=1065539
Jerry James <loganje...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution|--- |CURRENTRELEASE
Last Closed| |2014-05-19 11:59:43
--- Comment #14 from Jerry James <loganje...@gmail.com> ---
(In reply to Pádraig Brady from comment #13)
> BTW this loop looks very inefficient:
>
> for filt in filters/*; do
> sed 's,/usr/bin/env ,/usr/bin/,' $filt > ${filt}.new
> chmod 0755 ${filt}.new
> touch -r $filt ${filt}.new
> mv -f ${filt}.new $filt
> done
>
> Could it be replaced with:
>
> sed -i 's,/usr/bin/env ,/usr/bin/,; q' filters/*
>
> or
>
> find filters/ -exec sed -i 's,/usr/bin/env ,/usr/bin/,; q' {} +
Neither of the latter 2 preserves timestamps or fixes the missing executable
bits on subunit-output. In any case, there are only 13 files that are
processed in this way. Even if it is inefficient, it is still only a minuscule
fraction of the total build time:
real 0m0.135s
user 0m0.011s
sys 0m0.030s
Compared to the total number of minutes taken by a build, this just isn't worth
optimizing, in my opinion, especially when doing so leads to loss of
functionality (i.e., the timestamp and executable bit fixes).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
