https://bugzilla.redhat.com/show_bug.cgi?id=1099269



--- Comment #1 from Parag AN(पराग) <panem...@gmail.com> ---
Review:

+ Package builds successful in F21 x86_64 mock

+ rpmlint on generated rpms gave
drupal7-admin_theme.noarch: W: spelling-error Summary(en_US) Drupal -> Drupe
drupal7-admin_theme.noarch: W: spelling-error %description -l en_US Drupal ->
Drupe
drupal7-admin_theme.noarch: E: incorrect-fsf-address
/usr/share/doc/drupal7-admin_theme/LICENSE.txt
drupal7-admin_theme.src: W: spelling-error Summary(en_US) Drupal -> Drupe
drupal7-admin_theme.src: W: spelling-error %description -l en_US Drupal ->
Drupe
2 packages and 0 specfiles checked; 1 errors, 4 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: ab3b742c9854ddad5862e197b17bcc2bc655a5f101df7ab31a055c0e7f25c00f
upstream tarball :
ab3b742c9854ddad5862e197b17bcc2bc655a5f101df7ab31a055c0e7f25c00f

+ License is valid GPLv2+ and included in its own text file LICENSE.txt

+ Package follows drupal7 packaging guidelines

Suggestions:
1) Group tag is not necessary in Fedora now and can be removed from spec file.
See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

2) Buildroot tag is not needed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

3) File upstream bug/ticket to correct the FSF address in LICENSE.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to