https://bugzilla.redhat.com/show_bug.cgi?id=1103554

Ralf Corsepius <rc040...@freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040...@freenet.de



--- Comment #4 from Ralf Corsepius <rc040...@freenet.de> ---
This package has lot of issues. I do not want to sound too negative, but I fear
it'll be a long and tiresome process to get this package into Fedora.

Let start with pointing out a few selected issues.

1. Packaging:
Please properly split the package into <main> and *-devel subpackages:
- *.so.* belong into *-devel unless they are dlopened by name.
- man3/ are devel doc and therefore belong into *-devel.
- *.a are not supposed to be shipped in Fedora at all.
- Please be more selective in %files sections. The way you have written them is
very sensitive to accidentially picking up files a package is not supposed to
contain (cf. *devel vs. <main>).

2. Contents:
- Most of the man3/* manpages are junk and are likely to conflict with other
packages.
- The *-doc package contains a lot of files which are not supposed to be
shipped.

3. Bundled libraries:
This package bundles quite a number of sources from other origins (boost,
json2*.js, sha1, etc.). Please modify the package to use external versions
whenever possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to