https://bugzilla.redhat.com/show_bug.cgi?id=825409
--- Comment #38 from Scott K Logan <log...@cottsay.net> --- Okay, I've done some more thorough testing. Lets first talk about the things I mentioned before: - %cmake macro - Addressed - make threading - Addressed - bundled fonts - Addressed - new version - Addressed Now for some new things: - Gazebo 3.0 added a build dependency on gdal-devel. This needs to be added as a run dependency in gazebo-devel [1]. - The fix for linking against player seems to have disappeared [2]. - We talked offline about this, but there is a pretty big difference in the way boost is influencing the behaviour of gzclient when there is no gazebo server running. The intended behaviour is that gzclient tries for 30 seconds and gives up. You should incorporate a patch to fix this, or Gazebo is essentially impossible to start using roslaunch [3]. - Since Gazebo explicitly needs sdformat 2, you should specify that in the build requirement. It took me a while to figure out why I couldn't build the new package...of course, updating sdformat to the newest RPM fixed it. - I found that when I added the correct PATH and LD_LIBRARY_PATH to the %check section, a large amount of the tests started working. Additionally, I analyzed the remaining three and found reasons that they may never work in fedora's build environment. I then blacklisted these tests, so all of them were succeeding when I built in mock on build slave. It looks like there are more tests that fail when built in Koji, so removing the /usr/bin/true from `make test` probably isn't a good idea, but it might be worth investigating the Koji failures eventually. The changes are at [4] and [5]. - I see that the base package depends on -media, but I'm wondering if it wouldn't be a good idea for -media to depend on the base as well. That way, there is still a separate noarch packge for the assets, but -media will be uninstalled with the base package. There really isn't a reason to have one without the other... I've implemented the changes and tested them. Feel free to use them directly, modify them, or not use them at all. I feel that this package is very close to being ready! [1] https://github.com/cottsay/gazebo-rpm/commit/7944d7b51eb222291c1a64df34cdc7c0392f48a4 [2] https://github.com/cottsay/gazebo-rpm/commit/324f8e798473ca3d75aaed2883732eb6b5f36917 [3] https://github.com/cottsay/gazebo-rpm/commit/78c86e05018377f6b7acaa40d7845377fb757b99 [4] https://github.com/cottsay/gazebo-rpm/commit/19df7f9ad2a7cc7ad80160e6296024fd54bb9c04 [5] https://github.com/cottsay/gazebo-rpm/commit/68b8d4b6cc1891b291e8f2d5316b91e04f2755cc -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review