https://bugzilla.redhat.com/show_bug.cgi?id=1111561
--- Comment #8 from Christopher Meng <i...@cicku.me> ---
(In reply to Florian "der-flo" Lehner from comment #5)
Stop leaving any review template if this bug is already assigned to someone(and
being reviewed).
(In reply to Björn "besser82" Esser from comment #6)
> Why? I cannot see any reason for this… What you refer to is needed for
> header-only libs, when there is an arched mainpkg, but just a noarch-subpkg
> is really build. e.g. when having the main-pkg arched, because of running
> the testsuite on all avail arches during koji-build…
Who are you talking to?
Anyway(who is the reviewer?), here are the
Remaining issues:
1. No need to pass any arguments to make in %build, as the location variables
should be set in %install.
2. You should add %check with "make test". It's a good habit for a package with
testsuite. If the test can't be performed, write down the reason in comment.
3. #!/usr/bin/env python2
sed the matchword with %{__python2} macro substituted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
