https://bugzilla.redhat.com/show_bug.cgi?id=1111691

Jason Taylor <jason.tay...@secure-24.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason.tay...@secure-24.com



--- Comment #1 from Jason Taylor <jason.tay...@secure-24.com> ---
Hi David,

I would take a look at
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL for
your Source URL information.

http://fedoraproject.org/wiki/Packaging:DistTag also provides some information
on conditionals to clean up the rh_dist you define in the spec.

I am not sure if the suse/sles related conditional logic is allowable since it
isn't pertinent, someone else may be able to offer insight.

The duplicate License: declaration also seems unnecessary

%defattr is unnecessary

%clean is unnecessary unless supporting el5

http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to