https://bugzilla.redhat.com/show_bug.cgi?id=1107422
--- Comment #2 from Rich Mattes <richmat...@gmail.com> --- Thanks for the review! I've addressed the following: * Add more detailed descriptions * Add versioned Requires where available * Added comments about license breakdown and patch status * Fixed package ownership issues * Fixed bugs with breaking the libraries up into separate packages There's a couple of things I'm not sure about: * The source URL (derived from the commit hash) is needed as per the github packaging guidelines at http://fedoraproject.org/wiki/Packaging:SourceURL#Github. I think the problem with the github "releases" is that they're based on tags, which are mutable * The ldconfig snippets in post and postun follow the guidelines at https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries, I don't think there needs to be a macro for sbindir (which expands to /usr/sbin, not /sbin) With that, here are the updated packages: Spec URL: http://rmattes.fedorapeople.org/RPMS/octomap/octomap.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/octomap/octomap-1.6.6-2.fc20.src.rpm $ rpmlint ../RPMS/x86_64/octomap-* ../RPMS/x86_64/dynamic-edt-3d-* ../RPMS/noarch/octomap-doc-1.6.6-2.fc20.noarch.rpm ./octomap.spec octomap.x86_64: W: spelling-error %description -l en_US octree -> trochee octomap.x86_64: W: no-manual-page-for-binary bt2vrml octomap.x86_64: W: no-manual-page-for-binary binvox2bt octomap.x86_64: W: no-manual-page-for-binary log2graph octomap.x86_64: W: no-manual-page-for-binary convert_octree octomap.x86_64: W: no-manual-page-for-binary graph2tree octomap.x86_64: W: no-manual-page-for-binary edit_octree octomap.x86_64: W: no-manual-page-for-binary compare_octrees octomap.x86_64: W: no-manual-page-for-binary eval_octree_accuracy octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/OcTreeDrawer.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/SceneObject.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/ViewerWidget.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/ViewerSettings.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/CameraFollowMode.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/SelectionBox.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/OcTreeDrawer.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/OcTreeRecord.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/CameraFollowMode.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/TrajectoryDrawer.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/ViewerSettings.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/TrajectoryDrawer.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/PointcloudDrawer.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/ViewerSettingsPanel.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/ViewerSettingsPanelCamera.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/ColorOcTreeDrawer.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/SelectionBox.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/ViewerGui.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/ViewerSettingsPanel.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/main.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/ColorOcTreeDrawer.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/ViewerSettingsPanelCamera.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/ViewerWidget.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/SceneObject.h octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/src/PointcloudDrawer.cpp octomap-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/octomap-6d85527c3c1c50f52f3e591ba35154f0d1ff9cf8/octovis/include/octovis/ViewerGui.h octomap-devel.x86_64: W: no-documentation octomap-octovis.x86_64: W: spelling-error %description -l en_US libQGLViewer -> interviewer octomap-octovis.x86_64: W: no-manual-page-for-binary octovis octomap-octovis-devel.x86_64: W: no-documentation octomap-octovis-devel.x86_64: E: incorrect-fsf-address /usr/include/octovis/SelectionBox.h octomap-octovis-devel.x86_64: E: incorrect-fsf-address /usr/include/octovis/OcTreeRecord.h octomap-octovis-devel.x86_64: E: incorrect-fsf-address /usr/include/octovis/PointcloudDrawer.h octomap-octovis-devel.x86_64: E: incorrect-fsf-address /usr/include/octovis/OcTreeDrawer.h octomap-octovis-devel.x86_64: E: incorrect-fsf-address /usr/include/octovis/SceneObject.h octomap-octovis-devel.x86_64: E: incorrect-fsf-address /usr/include/octovis/TrajectoryDrawer.h octomap-octovis-devel.x86_64: E: incorrect-fsf-address /usr/include/octovis/ColorOcTreeDrawer.h dynamic-edt-3d.x86_64: W: spelling-error %description -l en_US updatable -> uneatable dynamic-edt-3d.x86_64: W: spelling-error %description -l en_US updatable -> uneatable dynamic-edt-3d-devel.x86_64: W: no-documentation dynamic-edt-3d-devel.x86_64: W: no-documentation octomap-doc.noarch: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen 10 packages and 1 specfiles checked; 33 errors, 18 warnings. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7069720 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
