https://bugzilla.redhat.com/show_bug.cgi?id=1055378



--- Comment #31 from Shawn Starr <shawn.st...@rogers.com> ---
Comments...

- Source1: icinga.tmpfiles.conf

* This is fixed, thanks

- Why is there gui and gui-config, if there is only 1 single gui-config
package, couldn't they be merged to simplify packaging ?

* Michael addressed this ans Icinga 2.x is released now.

-
    %if 0%{?el7}%{?fc20}%{?fc21}%{?fc22}
this is not very elegant, shouldn't it just be check against EL6 and disable
systemd requires ( and if you go this way, please also take care of the
requires on systemd-units ).

* I've ripped this all out, this is for Fedora 20/21/EPEL7

- BuildRequires gcc is not needed

* Removed

- There is a few unowned directory

******* More eyes would help, if you see some let me know I will add %dir tags
for them please ********

- License file is not installed in all case ( like if I install just the doc or
just guide-config )

* Added

- Could upstream be notified for the config.guess / config.sub issue ( so we
can drop the explicit requires on libtool ) ?

* Upstream has done this

- %defattr(-,root,root,-)  is not needed, please remove as the spec is already
long enough :)

* I've removed this specific entry but need the others however.


SPEC:  http://spstarr.fedorapeople.org/packages/icinga/icinga.spec
SRPM:
http://spstarr.fedorapeople.org/packages/icinga/icinga-1.11.5-1.fc21.src.rpm

Please provide further feedback, the last thing I'd like is the SELinux pieces
in place.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to