Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=599715 --- Comment #8 from Lev Shamardin <shamar...@gmail.com> 2010-06-22 13:04:10 EDT --- I think it does not worth to wait for python-sphinx. I've created this bug (https://bugzilla.redhat.com/show_bug.cgi?id=606893) to make sure that the patch will be applied :) Now for the formal review part. MUST items: * OK - rpmlint outputs no errors, all warnings can be ignored. See at the end of the review. * OK - package is named according to guidelines. * OK - package spec file is named correctly. * OK - package does meet the packaging guidelines. * OK - package licensed under MIT License * OK - License field in the spec file matches the actual license. * OK - License is included to the package. * OK - spec file is written in American English. * OK - spec file is legible. * OK - the sources for the package match the upstream. 95d01864a053ec67e08d57fc369152f8 eventlet-0.9.9.tar.gz 95d01864a053ec67e08d57fc369152f8 eventlet-0.9.9.tar.gz.orig * OK - checked that package does compile on i386 and x86_64. * OK - architectures where the package does not work are unknown. * OK - package lists sane BuildRequires. * OK - package does not use locales. * OK - package does not contain dynamic libraries. * OK - package does not bundle copies of system libraries. * OK - package is not relocatable. * OK - package owns all directories it creates. * OK - %files listings are correct. * OK - permissons on files are set correctly, %defattr is included in all %files sections. * OK - package contains code or permissible content. * OK - large documentation is stripped off (provided in fedora builds in a separate subpackage). * OK - package %doc contents does not affect it's runtime. * OK - package does not provide header files. * OK - package does not provided static libraries. * OK - package does not provide libraries with a suffix. * OK - package does not have a -devel subpackage. * OK - package does not contain .la files. * OK - package does not contain a GUI application. * OK - package does not own files or directories owned by other packages. * OK - all file names are UTF-8. SHOULD items: * OK - the package builds in mock. * OK - the pacakge functions as described. * OK - the package does not use scriplets. * OK - the package does not provide pkgconfig files. * OK - the package does not have file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin. rpmlint output: $ rpmlint python26-eventlet.spec python26-eventlet-0.9.9-1.el5.src.rpm python26-eventlet-0.9.9-1.el5.noarch.rpm python26-eventlet.src: W: spelling-error %description -l en_US scalability -> availability, sociability, inviolability python26-eventlet.src: W: spelling-error %description -l en_US io -> oi, Io, ii python26-eventlet.src: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, subroutines python26-eventlet.noarch: W: spelling-error %description -l en_US scalability -> availability, sociability, inviolability python26-eventlet.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii python26-eventlet.noarch: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, subroutines 2 packages and 1 specfiles checked; 0 errors, 6 warnings. All can be ignored. I'm approving this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
