https://bugzilla.redhat.com/show_bug.cgi?id=1087855



--- Comment #9 from Johan Swensson <k...@kupo.se> ---
(In reply to Christopher Meng from comment #8)
> 1. For new version please reset the %release to 1, I don't want to see
> something like 4.0.0-100 in the future.
Of course, as you can see in the changelog I did that but I had to bump the
release tag a few times as I'm maintaining a Copr for this package for testing
purposes.

> 2. Desktop file contains deprecated "Encoding" key, you should remove it.
Fixed.

> 3. LDFLAGS="%{__global_ldflags}"
> 
> EL6 doesn't have it. Use LDFLAGS="%{?__global_ldflags}" instead.
Fixed.


Spec URL: http://opuk.fedorapeople.org/scite.spec
SRPM URL: http://opuk.fedorapeople.org/SRPMS/scite-3.4.4-7.fc20.src.rpm
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=7136542

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to