https://bugzilla.redhat.com/show_bug.cgi?id=1023771
Vincent Batts <vba...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vba...@redhat.com
Assignee|mario.blaetterm...@gmail.co |vba...@redhat.com
|m |
--- Comment #2 from Vincent Batts <vba...@redhat.com> ---
Created attachment 918507
--> https://bugzilla.redhat.com/attachment.cgi?id=918507&action=edit
spec tweaks
Looks pretty good. A couple of points (and a patch to reference):
* removed a little boiler-plate, to use the golang rpm macros
* which makes a BuildRequires: golang
* preserve timestamps of copied source ( and removed the redundant -r, since -a
does a recursive copy)
* Stub out for future tests. Hopefully upstream will provide *_test.go for us
to check against.
* removed ownership of directories that the golang rpm owns
Lastly, I'm not opposed to the break out of the pieces of %{import_path}, just
as long as we standardize on the use of %{import_path}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
