https://bugzilla.redhat.com/show_bug.cgi?id=1089493

jiri vanek <jva...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #3 from jiri vanek <jva...@redhat.com> ---
Two non blocking questions
 - Any tests (for %check skope)  are I guess out of any scope, right? Sad :(
 - Is this pure bash? If it depends on bashism, can it be fixed to not relay
onbashism but be ok with any shell? If not, shouldnt be bash as requires? I
know that bash is in group of not necessary (== sure) requires, but maybe in
this case it is worthy to include.

Anyway grate job. I 'm happy that I found this in reviwe waiting list. Tank you
for it. 

If you are wiling of swap review, see
https://bugzilla.redhat.com/show_bug.cgi?id=1121402 ,  but dont feel yourself
in debt.

Ok. to go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to