Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=603628 --- Comment #2 from Pravin Satpute <psatp...@redhat.com> 2010-06-25 02:15:26 EDT --- + package builds in mock (rawhide i686). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2271467 + rpmlint is silent for SRPM and for RPM. aldusleaf-crimson-text-fonts.src: W: no-buildroot-tag not required from f13 aldusleaf-crimson-text-fonts.noarch: W: obsolete-not-provided crimson-text-fonts ok, since changes happened in devel only + source files match upstream url 4fde45b7b447e558da9585826734cd7b crimson_text_100608.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. - package installed properly. 1) a) Crimson Text Roman (Book, Semibold, Bold) b) Crimson Text Italic (Book, Semibold, Bold) are the two these are 2 families but when we install it show in font selection Crimson Text - Italit Roman Semibold Semibold Bold Bold so user cant recognize, which one is roman and which one italic family suggestion: use family name 1) Crimson Text Roman and 2) Crimson Text Italic in .sfd file 2) It will be good to make two subpackages a) will be aldusleaf-crimson-text-roman-fonts a) will be aldusleaf-crimson-text-italic-fonts it will give birth to common package as well, as per fonts spec guideline + Macro use appears rather consistent. + Package contains code, not content. // ask this + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + fonts scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
