https://bugzilla.redhat.com/show_bug.cgi?id=1128384



--- Comment #2 from Josef Stribny <jstri...@redhat.com> ---
Thanks for the informal review.

> Package doesn't match the upstream:

Did you compare it with the right released tag (2.2.1)[1] or with master? I
didn't do any modifications to those files. I added this step to the specfile's
comments so it's clearer now.


> Consistent use of macros:

I united the macros and changed the paths without macros to use them.


> Rpmlint

This is how the obs-sign is designed to be run by upstream. Do you have any
concrete objection on what rpmlint says?


Spec URL: http://data-strzibny.rhcloud.com/obs/obs-signd.spec
SRPM URL: http://data-strzibny.rhcloud.com/obs/obs-signd-2.2.1-2.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7438778


[1] https://github.com/openSUSE/obs-sign/tree/2.2.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to