https://bugzilla.redhat.com/show_bug.cgi?id=1133950
Christopher Meng <i...@cicku.me> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |i...@cicku.me
--- Comment #1 from Christopher Meng <i...@cicku.me> ---
1. Do not use "-f install_manifest.txt", list files explicitly.
2. BuildRequires: bzr >= 2.0
Why?
3. BuildRequires: libtool >= 1.5.24
Why?
4. BuildRequires: bison ncurses zlib-devel autoconf automake cmake
ncurses is wrong, should be ncurses-devel
autoconf and automake are needed by projects using autofools. This project uses
cmake. I couldn't see reasons of BRing them.
5. Use %cmake instead of cmake . -DCMAKE_INSTALL_PREFIX=/usr
6. Drop [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
7. changelog section invalid syntax.
8. License: LGPLv2.1 LGPLv2.1
Wrong
9. Release: 1
Wrong
10. Too long:
Summary: Client library used to connect apps. developed in C/C++ to MariaDB and
MySQL databases
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
