https://bugzilla.redhat.com/show_bug.cgi?id=226209

Vitezslav Crhonek <vcrho...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(vcrhonek@redhat.c |
                   |om)                         |



--- Comment #9 from Vitezslav Crhonek <vcrho...@redhat.com> ---
Sorry for (very) late response.

rpmlint: 
./nut.spec:125: W: macro-in-comment %patch4
./nut.spec:131: W: macro-in-comment %patch10
./nut.spec:132: W: macro-in-comment %patch11
./nut.spec: W: patch-not-applied Patch4: nut-2.6.5-ipmifix.patch

Any reason to not apply Patch4?
Patches number 10 and 11 are not defined at all, removing comments with them
will do no harm.

./nut.spec:387: E: hardcoded-library-path in
/lib/systemd/system-shutdown/nutshutdown

Isn't it possible to use some rpm macro here?

nut-client.x86_64: W: one-line-command-in-%postun /sbin/ldconfig
nut-devel.x86_64: E: incorrect-fsf-address /usr/include/nutscan-ip.h

Just to let you know about it, really minor issues. Otherwise it looks fine,
IMO the review can be closed.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to