https://bugzilla.redhat.com/show_bug.cgi?id=1141711
Lubomir Rintel <lkund...@v3.sk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #14 from Lubomir Rintel <lkund...@v3.sk> ---
* Package named correctly
* Correct version tag
* License tag mostly fine (see below)
* License OK for Fedora
* SPEC file clean and legible
* Builds fine in mock
* RPMlint reasonably happy
* Filelists sane
* Dependency chain sane
0.) You seem to bundle jQuery
Bundling is generally no-go, but this is already done by many packages, with
some plan to move forward but no appropriate solution at present:
http://fedoraproject.org/wiki/Changes/jQuery
Therefore I'd say this one is good to go, but please change your License tag
stating that you also ship MIT-licensed code (and add a comment above the
License tag explaining which license is for jQuery and which for FusionForge
code).
I'm not holding the review back for this; please do that upon import.
The package is APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
