https://bugzilla.redhat.com/show_bug.cgi?id=1151747
--- Comment #7 from pjp <pj.pan...@yahoo.co.in> ---
Hello Robert,
(In reply to Robert Mayr from comment #6)
> 1) The guidelines for the github commit contain also a shortcommit
> instruction. I think it's better to add it.
It's not used in the spec file. I think it's used for 'pre-release'
packages.[1]
---
...If no numeric version is indicated in the code, you may set Version to 0,
and treat the package as a "pre-release" package (and make use of the
%{shortcommit} macro).
---
> 2) You should use either $RPM_BUILD_ROOT or %{buildroot}, don't mix them up.
Fixed.
> 3) in the %files section you have %{_datadir}/* - is the package the owner
> of all the stuff beside it? It's better to define the single directories
> separately, IMHO.
done.
> 4) Use valid macros for the name instead of hardcoding
...?
> 5) Your desktop file has a deprecated "Encoding" instruction in the [Desktop
> Entry] section.
Fixed. (I'll let the upstream know about it)
Please see:
-> https://pjp.fedorapeople.org/onionshare.spec
-> https://pjp.fedorapeople.org/onionshare-0.6-4.fc19.src.rpm
-> http://koji.fedoraproject.org/koji/taskinfo?taskID=7851242
Thank you.
---
[1] -> https://fedoraproject.org/wiki/Packaging:SourceURL#Github
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
