https://bugzilla.redhat.com/show_bug.cgi?id=1157255
Igor Gnatenko <i.gnatenko.br...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |i.gnatenko.br...@gmail.com
--- Comment #2 from Igor Gnatenko <i.gnatenko.br...@gmail.com> ---
># don't use %%configure, UFOAI doesn't like default configure options
>./configure \
> --disable-dependency-tracking \
> --prefix=%{_prefix} \
> --bindir=%{_bindir} \
> --datadir=%{_datadir}/%{name} \
> --libdir=%{_libdir}/%{name} \
> --localedir=%{_datarootdir}/locale \
> --disable-testall \
> --enable-ufoded \
> --enable-uforadiant \
> --enable-ufo2map \
> --enable-ufomodel \
> --enable-release
how about %configure --enable-ufoded --enable-release..... ?
>%clean
>rm -rf %{buildroot}
and
>%defattr(-,root,root,-)
not needed
>%dir %{_datadir}/icons/hicolor/
>%dir %{_datadir}/icons/hicolor/32x32/
>%dir %{_datadir}/icons/hicolor/32x32/apps/
No, don't own this dirs.
$ rpm -qf /usr/share/icons/hicolor/
hicolor-icon-theme-0.13-2.fc21.noarch
>Firstly the opengl wrapper was disabled when I adopted the package. I am not
>>sure why it was done and how important wrapper is.
If game works ok - then you can remove it. For example, teeworlds buggy without
it.
># we need to use full path so %%doc does not the cleanup
>%dir %{_docdir}/%{name}-%{version}
>%doc %{_docdir}/%{name}-%{version}/README
>%doc %{_docdir}/%{name}-%{version}/COPYING
use %doc instead. for f20+ or f21+ we're using non-versioned doc dirs.
>Also building of documentation is disabling because (I think) making pdf leads
>>to huuuuge build dependencies. And nobody ever reads manuals anyway :)
I'd enable it. PDF is cool =)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
