https://bugzilla.redhat.com/show_bug.cgi?id=1151462
--- Comment #15 from Parag AN(पराग) <panem...@gmail.com> ---
Its been more than 10 days now since my last comment. Hope you could have found
time to review other people packages. Can you paste the links for those package
reviews here?
About your recent updated srpm. I have some suggestions
1) about look of spec file. It will be good to write every BuildRequires and
Requires per line. E.g.
BuildRequires: desktop-file-utils, ruby-devel
should be
BuildRequires: desktop-file-utils
BuildRequires: ruby-devel
Same for Requires: line
2) It will be good for people reading your spec to read it clearly. So
following
Name:belen
Version:0.1
Release:5%{?dist}
Summary:GUI down-loader for Linux
License:GPLv3
URL:https://github.com/n0oir/belen
Source0:https://n0oir.fedorapeople.org/%{name}-%{version}.tar.gz
BuildArch:noarch
can be written as
Name: belen
Version: 0.1
Release: 5%{?dist}
Summary: GUI down-loader for Linux
License: GPLv3
URL: https://github.com/n0oir/belen
Source0: https://n0oir.fedorapeople.org/%{name}-%{version}.tar.gz
BuildArch: noarch
3) desktop-file-install line should be written as
desktop-file-install \
--dir=%{buildroot}%{_datadir}/applications \
%{name}.desktop
4) At one place buildroot macro is written differently
%buildroot should be %{buildroot}
5) Summary should be "Frontend of youtube-dl made in Ruby Gtk+3"
6) %description should be
Belen is a GUI of command youtube-dl made in Ruby and GTK+3 with this you can
download multimedia content and full playlist from
* youtube
* dailymotion
* vimeo
* etc...
for the complete list visit http://rg3.github.io/youtube-dl/supportedsites.html
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
