https://bugzilla.redhat.com/show_bug.cgi?id=770740
Raphael Groner <projects...@smart.ms> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nob...@fedoraproject.org |projects...@smart.ms
--- Comment #11 from Raphael Groner <projects...@smart.ms> ---
Your spec file is not ready for a formal review. Please fix following listed
points. After done that, I could have a deeper look.
> # Tarballs can be obtained from GitHub at
> https://github.com/laas/morse/tarball/0.4.1
> Source0: laas-morse-0.4.1-0-g15dc857.tar.gz
%global name morse
%global commit g15dc857
%global version 0.4.1
Source0:
https://github.com/laas/%{name}/tarball/%{version}#/laas-name-%{version}-0-%{commit}.tar.gz
Analogously, you should give the individual URL directly into PatchX.
> %{?with_pocolibs:
What's that? I would not suggest conditional packaging. What is the purpose?
> Requires: %{name}%{?_isa} = %{version}-%{release}
Remove %{?_isa} completely from Requires. Otherwise, you won't be able to build
cross-arch.
> BuildRequires: swig
> BuildRequires: pocolibs-devel
Move those on top to the BR for the main package. There's only one %build
allowed for all sub-packages.
> %build:
You should use %cmake macro instead of direct cmake call with tons of standard
parameters.
https://fedoraproject.org/wiki/Packaging:Cmake?rd=Packaging/cmake
> pushd doc
> make
> popd
cd doc ; make
> %install
> desktop-file-install --vendor="fedora" \
The Vendor tag should not be used. It is set automatically by the build system.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Tags
> # Move …
Use install -d instead of mkdir -p to preserve timestamps etc.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
