Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611476 Randall Berry <randyn3...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |randyn3...@gmail.com --- Comment #1 from Randall Berry <randyn3...@gmail.com> 2010-07-06 04:19:49 EDT --- I'm not a sponsor but I can tell you a few things just from looking at the source. 1) You misspelled dhcp in the description note its spelled dchp instead. 2) In the spec file the %files section the attributes should be %defattr(-,root,root,-) not %defattr(-,root,root) 3) I'm not too sure about the licensing of the source. It contains GPL licenses in the tar ball but also some of the source code contains the statements like "Copyright, ... All rights reserved". Perhaps there should be some clarification there. Just a few thoughts as I pass by.. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
