https://bugzilla.redhat.com/show_bug.cgi?id=1162148
Lubomir Rintel <lkund...@v3.sk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|lrin...@redhat.com |
Flags|fedora-review? |
--- Comment #1 from Lubomir Rintel <lkund...@v3.sk> ---
0.) Please remove these, they're useless:
-%global shortname flabi
-# wersja 1.1
1.) The summary is too long and complicated. rpmlint complains:
-Summary: Conscript (artifical font) letters consist of vertical and
horizontal bars. No matter their thickness.
+Summary: Artificial font consisting of vertical and horizontal bars
2.) An extra and useless argument:
-%setup -q -c %{fontname}-%{version}-ttf
+%setup -q -c
3.) Useless comments with macros in them (rpmlint complains)
-# This was wrong:
-# mkdir -p %{buildroot}-%{shortname}
-# cp -p *.ttf %{buildroot}-%{shortname}
-# _fontdir expands to /usr/share/fonts/labirintowy
...
-# This generates the files section:
...
-# This is useless -- it gets generated with _font_pkg too:
-# %files %{buildroot}-%{shortname}/*.ttf
4.) Please use a more reasonable name & address in changelog. Someone might
want to contact you:
* Tue Nov 4 2014 <adres jest niedostepny pl> 1.53
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
