https://bugzilla.redhat.com/show_bug.cgi?id=1155793
Christopher Meng <i...@cicku.me> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |i...@cicku.me
Assignee|nob...@fedoraproject.org |i...@cicku.me
Summary|Review Request: Hyperrogue |Review Request: hyperrogue
|- An SDL roguelike in a |- An SDL roguelike in a
|non-euclidean world |non-euclidean world
--- Comment #6 from Christopher Meng <i...@cicku.me> ---
Hi,
I just went through your spec and found some problems you have to fix.
1.
BuildRequires: SDL_mixer-devel SDL_ttf-devel SDL_gfx-devel
BuildRequires: desktop-file-utils
Requires: SDL_mixer SDL_ttf SDL_gfx
If linker works well, no need to explicitly Requires SDL_mixer SDL_ttf SDL_gfx.
2. Summary: An SDL rogue-like in a non-euclidean world
Arr... rogue-like or roguelike exactly?
3. # Upstream no provides the install target. I have to install files "by
hand".
mkdir -p %{buildroot}%{_libdir}/%{name}
cp -p hyper %{buildroot}%{_libdir}/%{name}/hyperrogue
cp -p *ogg %{buildroot}%{_libdir}/%{name}/
cp -p VeraBd.ttf %{buildroot}%{_libdir}/%{name}/
Although install target is unavailable, yours is not good.
These files should be put into %{_datadir}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
