https://bugzilla.redhat.com/show_bug.cgi?id=1170629

Matthias Runge <mru...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mru...@redhat.com
           Assignee|nob...@fedoraproject.org    |mru...@redhat.com



--- Comment #1 from Matthias Runge <mru...@redhat.com> ---
Ihar,
just a few annotations before I'll do a proper review.
- please adjust python macros:
https://fedoraproject.org/wiki/Packaging:Python#Macros
- setuptools is missing from builddepencencies
- please remove egg-info in %prep section
- please be more specific in files section. To avoid accidental inclusion of
other files, try to narrow that list down as much as possible.
e.g %{python_sitelib}/ncclient 
won't hurt.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to