https://bugzilla.redhat.com/show_bug.cgi?id=1170812

Parag AN(पराग) <panem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panem...@gmail.com
           Assignee|nob...@fedoraproject.org    |panem...@gmail.com
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panem...@gmail.com> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-astral.noarch: W: spelling-error %description -l en_US modularity ->
molecularity
nodejs-astral.noarch: W: spelling-error %description -l en_US llvm -> llama
nodejs-astral.noarch: W: only-non-binary-in-usr-lib
nodejs-astral.noarch: W: dangling-symlink
/usr/lib/node_modules/astral/node_modules/clone /usr/lib/node_modules/clone
nodejs-astral.src: W: spelling-error %description -l en_US modularity ->
molecularity
nodejs-astral.src: W: spelling-error %description -l en_US llvm -> llama
2 packages and 0 specfiles checked; 0 errors, 6 warnings.


+ Source verified with upstream as (sha256sum)
srpm tarball: 705a7fd67fe7ccff2d965bdfc8fcc70021e5938efb07998ee378424425f1e04f
upstream tarball:  
705a7fd67fe7ccff2d965bdfc8fcc70021e5938efb07998ee378424425f1e04f

+ License is "MIT" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) Should ask upstream to add license text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to