https://bugzilla.redhat.com/show_bug.cgi?id=1172800
Dan Horák <d...@danny.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |d...@danny.cz
--- Comment #3 from Dan Horák <d...@danny.cz> ---
Hi Petr,
a couple notes
- you should drop the %defattr()s from %files, rpmbuild sets them automagically
- similar for rm -rf $BUILDROOT" in %install, rpmbuild takes care of it
- my personal preference is having each BuildRequires on its own line, it is
easier to track the changes in BRs
- add %dir %{_includedir}/libzwerg to %files libzwerg-devel, otherwise the dir
will be unowned
Nice to see using package's own tool to explain the exit() call :-)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
