https://bugzilla.redhat.com/show_bug.cgi?id=1173683
--- Comment #2 from Pavel Raiskup <prais...@redhat.com> --- Created attachment 969469 --> https://bugzilla.redhat.com/attachment.cgi?id=969469&action=edit possible fixes Per fedora-review script (unless you plan to build against EPEL5): ===== MUST items ===== [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/pgsql, /usr/share/pgsql, /usr/share/pgsql/extension praiskup: we need to require postgresql-server (and ideally MODULE_COMPAT) [!]: %build honors applicable compiler flags or justifies otherwise. praiskup: CFLAGS are inherited from postgresql-devel currently [x]: Package is named according to the Package Naming Guidelines. praiskup: however, I would prefer pg-semver (semver is different project) [!]: Rpmlint is run on all rpms the build produces. praiskup: postgresql-libs requirement is redundant [!]: Package requires other packages for directories it uses. praiskup: we need to require postgresql-server ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
