https://bugzilla.redhat.com/show_bug.cgi?id=1168692
Vladimir Stackov <amigo.el...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |amigo.el...@gmail.com
--- Comment #2 from Vladimir Stackov <amigo.el...@gmail.com> ---
Greetings,
a few comments:
1. Why not to push latest SPEC to your pull-request?
I mean this: https://github.com/mystilleef/FedoraZram/pull/12/files
It could be merged and then you can use upstream SOURCE.
2. You could easily remove empty %build from your SPEC.
3. Package name is misleading. It's not related to zswap so you should probably
rename it to something like zramctl.
4. Why you don't want to include zramstat? It was very useful util.
5. Why you decided to use manual install instead of %makeinstall?
Thanks!
Please note that this is informal review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
