https://bugzilla.redhat.com/show_bug.cgi?id=1160671
Vladimir Stackov <amigo.el...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |amigo.el...@gmail.com
--- Comment #1 from Vladimir Stackov <amigo.el...@gmail.com> ---
Greetings,
a few comments on this review request:
1. Your packages (seafile and ccnet) both introduces build time requirements
(cross-package BuildRequires) so you should setup boostraping properly:
https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping
2. As you are packaging snapshot, you should use another name for the package:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github
3. You should consider using %makeinstall macros instead of make install
DESTDIR=%{buildroot}:
# rpm -E %makeinstall
4. You should consider enabling hardened builds:
https://fedoraproject.org/wiki/Packaging:Guidelines#PIE
5. You should use %license for license information instead of %doc.
6. Your package should contain correct .desktop file:
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
7. Use %{name}.1.* instead of %{name}.1.gz, since the compression method might
change at some point.
Please note that this is informal review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
