https://bugzilla.redhat.com/show_bug.cgi?id=1172141



--- Comment #10 from Adrien Devresse <ade...@gmail.com> ---
@Florian: Your opinion matter and your comments are naturally welcome.
I fixed the issue you mention on the last version of the spec file.

@Matthias: This is a package that targets EPEL5 too. 

The buildroot section and the clean section are needed for this plateform.
https://fedoraproject.org/wiki/EPEL:Packaging#BuildRoot_tag 
https://fedoraproject.org/wiki/EPEL:Packaging#Cleaning_BuildRoot_in_.25clean

Concerning the %defattr, they are indeed not needed. However, rpmlint under
EL5/EL6 spam a lot of warnings if %defattr missing. To be coherent, I usually
keep it.
If it is a problem from your perspective, I can remove it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to