https://bugzilla.redhat.com/show_bug.cgi?id=1175270
--- Comment #5 from Jonathan Dieter <jdie...@lesbg.com> ---
Thanks for your input. Comments inline:
(In reply to Igor Gnatenko from comment #4)
> > %configure --disable-static --with-usbids-dir=/usr/share/hwdata
> replace /usr/share with %{_datadir}
Done.
> > make DESTDIR=%{buildroot} install
> replace with %make_install
Done.
> > install -m ......
> for all install calls use '-p' flag to preserver datetime
Done.
> > Group: ....
> drop this tag
According to http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag, it's
optional and I'd rather keep it, thanks.
> other looks good to me
Thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
