https://bugzilla.redhat.com/show_bug.cgi?id=1182446
Adam Williamson (Fedora) <adamw+fed...@happyassassin.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nob...@fedoraproject.org |adamw+fedora@happyassassin.
| |net
Flags| |fedora-review+
--- Comment #1 from Adam Williamson (Fedora) <adamw+fed...@happyassassin.net>
---
Accepted. As a note, we already have the rest of phpseclib, and the spec
follows the other specs pretty closely, just unimportant detail differences.
rpmlint:
[adamw@adam SPECS]$ rpmlint
/home/adamw/rpmbuild/RPMS/noarch/php-phpseclib-file-asn1-0.3.9-1.fc22.noarch.rpm
php-phpseclib-file-asn1.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[adamw@adam SPECS]$ rpmlint
/home/adamw/rpmbuild/SRPMS/php-phpseclib-file-asn1-0.3.9-1.fc22.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[adamw@adam SPECS]$ rpmlint php-phpseclib-file-asn1.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Packaging guidelines MUST and SHOULD items: all are correct or N/A.
Package is approved.
(Personally I like not to have BuildRoot and defattr, as I'm not interested in
building for EL5 anyway, but it doesn't matter).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
