https://bugzilla.redhat.com/show_bug.cgi?id=1121601



--- Comment #17 from Jason Tibbitts <ti...@math.uh.edu> ---
Oh, good.  For me personally it's no big deal to write a bunch of selinux rules
to make it work.  A full list of even the less useful command-truncated AVCs
might help, though.  I guess I can have a look after I get the packages
installed.

Anyway, regarding this package, most of the review work is actually done.  The
package is extremely clean for its complexity, though given currently supported
Fedora versions, I would probably strip some of the version conditionals.  I
guess, though, there's always a chance that someone will try to build on RHEL4
or something and the conditionals could make it obvious that it won't work.

The only other thing I think I'd point out is the use of __rm is kind of odd,
since you don't use any other macro-ized executables besides __perl.  Why not
just use rm?  Or is this something related to the usrmove thing?  (I.e. you
don't know if you can require /bin/rm or /usr/bin/rm.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to